Skip to content

fix: a11y issue by removing unnecessary alternate text (#217)#218

Merged
jakebolam merged 4 commits into
all-contributors:masterfrom
AnandChowdhary:patch-1
Nov 28, 2019
Merged

fix: a11y issue by removing unnecessary alternate text (#217)#218
jakebolam merged 4 commits into
all-contributors:masterfrom
AnandChowdhary:patch-1

Conversation

@AnandChowdhary
Copy link
Copy Markdown
Contributor

@AnandChowdhary AnandChowdhary commented Nov 2, 2019 •
edited by Berkmann18
Loading

What: Fixed #217 – Removed the unnecessary alternate text from images.

Why: This is an accessibility issue. Screen readers read the name of the contributing user twice, which is incorrect. Decorative images are required to have empty alternate text, according to this W3C spec.

How: Changed alternate text attribute to alt="" in tests and implementation.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Depends on #221

@AnandChowdhary
Copy link
Copy Markdown
Contributor Author

AnandChowdhary commented Nov 2, 2019

Looks like the Circle CI test is failing because of an incompatible Node.js version in the semantic-release dependency:

error semantic-release@15.13.29: The engine "node" is incompatible with this module. Expected version ">=8.16". Got "8.14.0"

You probably want to change circleci/node:8.14.0 to circleci/node:8.16.2 in the .circleci/config.yml#L5 file.

--

@all-contributors, can you please add @AnandChowdhary for bug reports and code?

@allcontributors allcontributors Bot mentioned this pull request Nov 2, 2019
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Nov 2, 2019

@AnandChowdhary

I've put up a pull request to add @AnandChowdhary! 🎉

@Berkmann18
Copy link
Copy Markdown
Member

Berkmann18 commented Nov 6, 2019

Looks like the Circle CI test is failing because of an incompatible Node.js version in the semantic-release dependency:

error semantic-release@15.13.29: The engine "node" is incompatible with this module. Expected version ">=8.16". Got "8.14.0"

Cf. #221

@AnandChowdhary
Copy link
Copy Markdown
Contributor Author

AnandChowdhary commented Nov 28, 2019

Checks look good, looking forward to hearing from the team! :)

Link to relevant W3C example: https://www.w3.org/WAI/tutorials/images/decorative/#image-with-adjacent-text-alternative

@Berkmann18 Berkmann18 self-assigned this Nov 28, 2019
@jakebolam jakebolam changed the title Fixes #217 a11y issue by removing unnecessary alternate text fix: a11y issue by removing unnecessary alternate text (#217) Nov 28, 2019
@jakebolam jakebolam merged commit 3382821 into all-contributors:master Nov 28, 2019
@all-contributors-release-bot
Copy link
Copy Markdown
Member

all-contributors-release-bot commented Nov 28, 2019

🎉 This PR is included in version 6.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Berkmann18 pushed a commit that referenced this pull request May 24, 2020
@nschonni @jakebolam
chore(package): Bump all-contributors-cli (#218)
1740473 
* chore(package): Bump all-contributors-cli

* chore(test): Update snapshots
@juliaferraioli juliaferraioli mentioned this pull request Jun 5, 2022
Open
@lwasser lwasser mentioned this pull request Mar 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees

@Berkmann18 Berkmann18

Labels

released status: in review type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inaccessible HTML table code generated due to extra alt text

4 participants

@AnandChowdhary @Berkmann18 @all-contributors-release-bot @jakebolam