#1569 | Changed default value of schema.repository.deleteSchemaPathSuffix to empty string.#1754
Closed
adriansobolewski wants to merge 7 commits intoallegro:masterfrom
Closed
Conversation
…ffix to empty string. This has been done to make requests to default Confluent schema registry match its delete url.
…hods to read and modify the schema. Modified RawSchemaClient to provide only read methods.
adriansobolewski
force-pushed
the
change-deleteSchemaPathSuffix-default-value
branch
3 times, most recently
from
c2548ff to
2cf0f3f
Compare
adriansobolewski
force-pushed
the
change-deleteSchemaPathSuffix-default-value
branch
from
2cf0f3f to
6867e5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why on earth did I change so many lines just to change the default config value?
I've noticed that there is a "hacky" constructor with default values in
SchemaRegistryRawSchemaClient. So to change the default value ofdeleteSchemaPathSuffixI would have to make changes in two places:After analysis, I've found out that the default constructor is used to provide schema client to
hermes-frontendandhermes-consumers. Those default clients didn't even use thedelete/create/validatemethods, so I've introduced an read-only abstraction to get rid of this "hacky" constructor with default values.After this change changing the
deleteSchemaPathSuffixcan be done just in one place.Additionally, the code is cleaner and the read-only schema client is simpler and uses less dependencies.
If you don't like this change I can drop the commit with the refactor.