Changes to support Simularium integration #255
Conversation
…imated/volume-viewer into simularium-volumes
…imated/volume-viewer into simularium-volumes
frasercl
changed the title
This reverts commit 479df99.
frasercl
requested review from
ShrimpCryptid and
meganrm
and removed request for
a team
ShrimpCryptid
left a comment
ShrimpCryptid
left a comment
There was a problem hiding this comment.
Looking really good overall, had a couple questions but once they're clarified I'm good to approve 👍
| const { normPhysicalSize, normRegionSize } = this.volume; | ||
| // Set offset | ||
| this.geometryMesh.position.copy(this.volume.getContentCenter()); | ||
| this.geometryMesh.position.copy(this.volume.getContentCenter().multiply(this.settings.scale)); |
There was a problem hiding this comment.
Why does a volume's scale affect its offset position? Is the scaling origin always the origin of the scene?
There was a problem hiding this comment.
The offset position is relative to the center of the volume, which for this viewer should almost always be the origin of the scene. It's there to compensate for an irregular subregion. E.g. if the subregion in the x-axis were 0.5 - 1.0, getContentCenter would return 0.25 in the x-axis, because the center of the mesh has to move from the center of the volume bounding box to halfway to its edge:
Since that offset is in world units, it also has to account for the scale of the volume.
…imated/volume-viewer into simularium-volumes
…imated/volume-viewer into simularium-volumes
Review time: medium (20-30min). Most of the diff is package-lock.json!
Misc. changes required to incorporate volume rendering from this codebase into Simularium, including:
ImageInfo.transformto correspond to this, even though fields of that object are never read within the core package.VolumeDrawabletype.doRendermethod ofVolumeRenderImplno longer depends on our internalThreeJsPanelclass, and instead accepts the three.js objects it was previously getting from it.RayMarchedAtlasVolumenow generates its own fallback empty depth texture on its first render, to allow its render method to be called without a depth texture. (Future work should allow this class to accept the full view space position buffer generated by Simularium in its first render pass in place of a depth texture.) Producing this depth texture currently generates errors in Simularium, which is running a slightly older version of three.plugin-transform-runtime, to resolve some conflicts.