Skip to content

Pvs cleanup#36

Merged
allenh1 merged 16 commits intomasterfrom
pvs-cleanup
Sep 25, 2019
Merged

Pvs cleanup#36
allenh1 merged 16 commits intomasterfrom
pvs-cleanup

Conversation

@allenh1
Copy link
Copy Markdown
Owner

@allenh1 allenh1 commented Sep 25, 2019

This cleans up a good amount of the PVS studio detected errors.

New PVS log is here.

@allenh1
Use !temp.empty() instead of size
2a464c9 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Fix impossible condition on wildcard check
2d792fb 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Move the simple command functions into simple_command.cpp
9beef69 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Remove unused variable
bda13a3 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Fix possible (indeed probable) nullptr dereference
24f4bed 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Remove unused variable
945f846 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Remove unnecessary allocation
ebcf42c 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Avoid potential nullptr dereference
d9798b5 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Use std::make_shared
5bfa05d 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Avoid nullptr dereference
3d80daa 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1
Avoid nullptr dereference
9b1ecda 
Signed-off-by: Hunter L. Allen <hallen@kns.com>
@allenh1 allenh1 requested a review from mechaHarry September 25, 2019 00:59
@allenh1 allenh1 self-assigned this Sep 25, 2019
mechaHarry
mechaHarry approved these changes Sep 25, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mechaHarry mechaHarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logical equivalencies, syntax restructures, and pvs optimizations/patches all look great to me.

Lock n load baby,

  • mH

mechaHarry
mechaHarry requested changes Sep 25, 2019
View reviewed changes
Comment thread src/wildcard.cpp Outdated
@mechaHarry
Copy link
Copy Markdown
Collaborator

mechaHarry commented Sep 25, 2019

Seemed to fix the expected wildcarding output via latest push, but the pr still seems to miss one of the zombie cases; if we can resolve that, then this pr is ready to launch.

@allenh1
Copy link
Copy Markdown
Owner Author

allenh1 commented Sep 25, 2019

Seemed to fix the expected wildcarding output via latest push, but the pr still seems to miss one of the zombie cases

Yeah, that test has always been flakey. If it fails several times in a row I start to worry, but it usually works with a re-trigger.

Also, in the future, please refrain from adding commits to my PR... I squash merge, so your commits will all be creddited to me and you deserve credits!

Since the CI is green now, I'm going to merge this in.

@allenh1 allenh1 merged commit aca257e into master Sep 25, 2019
@allenh1 allenh1 deleted the pvs-cleanup branch September 25, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mechaHarry mechaHarry mechaHarry approved these changes

Assignees

@allenh1 allenh1

Labels

bug enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allenh1 @mechaHarry