Merged
Conversation
oblodgett
requested review from
cmpich and
markquintontulloch
and removed request for
markquintontulloch
oblodgett
commented
Sep 14, 2023
| } | ||
|
|
||
| private static boolean hasValidAlleles(AlleleDiseaseAnnotation da) { | ||
| List<String> alleleIds = (new AlleleRepository()).getAllAlleleIDs(); |
Member
Author
There was a problem hiding this comment.
@cmpich Repositories HAVE to be closed otherwise the indexer / cacher hangs.
Member
Author
There was a problem hiding this comment.
This is due to a persistent connection to Neo.
oblodgett
commented
Sep 14, 2023
|
|
||
| public List<String> getAllAlleleIDs() { | ||
| if (allAlleleIDs != null) | ||
| return null; |
Member
Author
There was a problem hiding this comment.
@cmpich the logic here should have been: if (allAlleleIDs != null) return allAlleleIDs;
Member
Author
There was a problem hiding this comment.
Plus there is no need to cache these as they should only get called a few times.
Contributor
There was a problem hiding this comment.
But I don't think this causes too much memory strain on the indexer. This will increase the timing of the indexer.
oblodgett
commented
Sep 14, 2023
| } | ||
| return list; | ||
| } | ||
|
|
cmpich
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.