Fix regex.inc documentation errors#1055
Merged
Headline merged 1 commit intoalliedmodders:masterfrom Jul 31, 2019
hydrogen-mvm:patch-1
Merged
Fix regex.inc documentation errors#1055Headline merged 1 commit intoalliedmodders:masterfrom hydrogen-mvm:patch-1
Headline merged 1 commit intoalliedmodders:masterfrom
hydrogen-mvm:patch-1
Conversation
https://steamuserimages-a.akamaihd.net/ugc/786360440444926021/3977E37BB5937C22C7C82A96DC503ED449F865B1/ Some methodmap documentation was a direct copypasta from the non-methodmap natives, mentioning a handle parameter which doesn't exist (since the "this" variable is the handle itself). A couple non-methodmap natives had the @param documentation in the wrong order, with the handle coming second. I think I fixed everything in this file. Please review and let me know of any changes that should be made. Thanks.
BotoX
pushed a commit
to BotoX/sourcemod
that referenced
this pull request
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://steamuserimages-a.akamaihd.net/ugc/786360440444926021/3977E37BB5937C22C7C82A96DC503ED449F865B1/
Some methodmap documentation was a direct copypasta from the non-methodmap natives, mentioning a handle parameter which doesn't exist (since the "this" methodmap variable is the handle itself). A couple non-methodmap natives had the @ param documentation in the wrong order, with the handle coming second in the doc string.
I think I fixed everything in this file. Please review and let me know of any changes that should be made. Thanks.
(EDIT: that @ param accidentally pinged someone. Oops sorry!!!)