Added much needed removewearables function. #117
Conversation
|
#114... |
plugins/include/tf2_stocks.inc
Outdated
There was a problem hiding this comment.
It appears this file was unfortunately left out of the PR. You should also consider using static or something else as well if you constantly need data.
|
A RemoveWearable native was already added to the TF2 Tools extension in commit 4a400d9. We tend to put features like this directly into natives so if something changes that would require a recompile (such as the C++ function prototype), consumer plugins would not all need to be recompiled. An IsWearable function would be better made in an extension where it wouldn't require gamedata as you can just check for the existence of the DT_TFWearableItem datatable on the entity. This isn't actually required for most use though, at least for RemoveWearable, due to its implementation. Trying to remove a non-wearable entity with it is essentially a no-op. As for EquipWearable, are there any uses for this that don't result in invisible items? Also, changes similar to what you have in TF2_RemoveWeaponSlot2 are already being discussed on bug 6206. The gamedata load of "ff2data" suggests that this is just a copy/paste of functionality from the popular FF2 plugin. If the work isn't yours, make sure to give credit where credit is due, at least noted in the PR., There are also numerous PrintToServer calls that don't really belong. If it's an error, an error should be thrown. If it's a warning important enough to be logged, it should be logged. Else, nothing. |
|
Additionally, when writing SDKCall stocks like that, you should cache the call handles rather than doing the gamedata lookup and call preparation each time that the function is called. |
|
Like psychonic said, #114 already seems to be fine for TF2_RemoveWearable, and there's a bug tracking TF2_RemoveWeaponSlot. FF2 does not use this "ff2data", so I suspect that it's from his fork of FF2 (FF2-Alpha). |
|
Credit to friagram for writing this, the ff2data thing I thought I changed.
|
Removed TF2_RemoveWearable stock as extension has it. TODO:Convert IsWearable to tf2 extension. Removed TF2_EquipWearable
|
I apologize for not being as clear as I could be. I don't think that IsWearable is necessary. Is there a use case for it besides checking before calling RemoveWearable? As I noted before, RemoveWearable does not care if the entity is a wearable or not. If it is not, the function will just do nothing, rather than cause a crash or other bad behavior. Additionally, changes to the TF2 stocks for removing weapons are already being discussed on bug 6206. Implementation should wait until we figure out how we want to handle it. You're welcome to join in the discussion there. |
|
I'll leave this PR open unless bug 6206 says otherwise. |
|
Closing this as the changes to tf2_stocks things are already implemented as well as physconic says that IsWearable isn't needed |
4 participants
No description provided.