Implement TF2_RemoveWearable native. #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 Any chance we could also get TF2_RemoveWeaponSlot to call this? |
Contributor
Author
|
@50Wliu I had planned to tackle that afterwards, if this PR got accepted. It's a considerably more tricky (and slightly off-topic) problem that may be better suited to a discussion in an AM bug. |
plugins/include/tf2.inc
Outdated
Member
There was a problem hiding this comment.
Does removing the wearable destroy the entity? I don't know, but I feel that the function doc should clarify.
Contributor
Author
|
CBasePlayer::RemoveWearable does a call to UTIL_Remove, so I've updated the doxygen comment to describe that behavior. |
Member
|
Looks good. |
psychonic
added a commit
that referenced
this pull request
Jul 30, 2014
Implement TF2_RemoveWearable native (r=psychonic).
Contributor
Author
|
@50Wliu I've filed a bug that you can CC yourself on if you want to follow any changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of late there's a pretty valid usecase for having to remove wearables.
TF2 botkiller weapons equip skull "fobs" to weapons that can't be cleanly removed without unequipping them from the player with a call to RemoveWearable.
Everyone seems to be implementing this function call within their own plugins, so it may be a better option to consolidate this behavior within the TF2 extension.