Fix automatic language detection on CS:GO (bug 6163).#124
Merged
Conversation
Member
|
🚢 |
psychonic
added a commit
that referenced
this pull request
Aug 11, 2014
Fix automatic language detection on CS:GO (bug 6163) (r=asherkin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in bug 6163, cl_language is no longer available as a userinfo var in CS:GO, breaking our automatic client language detection.
However, it does still exist, albeit hidden on the client. We are able to query the value.
There are some drawbacks to this compared to getting it from userinfo (inconsistent behavior across games, language not being available until shortly after PutInServer rather than Connect on CS:GO, extra logic running for every convar query in CS:GO), but I think that it's still better than nothing.