Skip to content

Fix the funcommands plugin resetting all players' color and transparency on round end#2446

Merged
psychonic merged 4 commits intoalliedmodders:masterfrom
RealBerke:funcommands-fix
Apr 26, 2026
Merged

Fix the funcommands plugin resetting all players' color and transparency on round end#2446
psychonic merged 4 commits intoalliedmodders:masterfrom
RealBerke:funcommands-fix

Conversation

@RealBerke
Copy link
Copy Markdown
Contributor

The code does not check if the command is active before removing its effects. Since these reset functions are also ran at the end of the round, they cause every player's set color and transparency to be reset when round ends even if the command was not activated and it was set by other means such as other plugins or maps. This goes against the default behaviour where player color and transparency persists between round resets, some maps may prefer to keep these between rounds.

Also removed the unnecessary color and transparency reset in beacon code as this plugin never sets those, so no need to reset it.

Copy link
Copy Markdown
Member

@psychonic psychonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The beacon changes looked good. For firebomb/timebomb, I think it was only fixing part of the issue. I've pushed a further fix for that. I also pushed a fix for an existing issue in firebomb where it was referencing the triggering client rather than the targeted one.

@psychonic psychonic merged commit 5d28ea6 into alliedmodders:master Apr 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants