Fix the funcommands plugin resetting all players' color and transparency on round end#2446
Merged
psychonic merged 4 commits intoalliedmodders:masterfrom Apr 26, 2026
Merged
Conversation
psychonic
approved these changes
Apr 26, 2026
Member
psychonic
left a comment
There was a problem hiding this comment.
Thanks!
The beacon changes looked good. For firebomb/timebomb, I think it was only fixing part of the issue. I've pushed a further fix for that. I also pushed a fix for an existing issue in firebomb where it was referencing the triggering client rather than the targeted one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code does not check if the command is active before removing its effects. Since these reset functions are also ran at the end of the round, they cause every player's set color and transparency to be reset when round ends even if the command was not activated and it was set by other means such as other plugins or maps. This goes against the default behaviour where player color and transparency persists between round resets, some maps may prefer to keep these between rounds.
Also removed the unnecessary color and transparency reset in beacon code as this plugin never sets those, so no need to reset it.