chore: remove dead code#41
Merged
Merged
Conversation
giunatale
requested review from
clockworkgr,
giuliostramondo,
julienrbrt and
tbruyelle
as code owners
julienrbrt
approved these changes
May 13, 2026
tbruyelle
approved these changes
May 14, 2026
giunatale
added a commit
that referenced
this pull request
May 14, 2026
* dead-code cleanup * remove ref to power-shaping in docstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove some dead errors/events/keys, align IDs for errors and collection prefixes, remove a stale comment and rename
EndBlockCIStoEndBlockTrackValsetUpdatesas legacy name was misleading.x/vaas/types/denom_helpers.gois completely deleted since it's unnecessary (using ibc-go v10, this shim is effectively dead code)I stayed conservative, but honestly there's quite a lot of dangling/potentially dead code all around the repo. It's only dead now maybe because it's scaffolding (like the
preVAASstuff for example), but a round of cleanup should be done again once implementation becomes more mature.Feel free to object to any of the changes, I may have accidentally removed some required things.