refactor: unify rate limiter stores behind a generic seam#131
Merged
Conversation
Replace two structurally identical token-bucket store implementations (rateLimiterStore keyed by uuid.UUID and tokenRateLimiterStore keyed by string) with a single generic rateLimiterStore[K comparable]. The shared getLimiter and cleanupStale logic now lives once; the two public middleware functions become thin adapters that supply a key extractor, a log attribute builder, and their message strings to a shared newRateLimitMiddleware factory. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rateLimiterStorekeyed byuuid.UUIDandtokenRateLimiterStorekeyed bystring) with a single genericrateLimiterStore[K comparable]in a newrate_limiter.gofilegetLimiter,cleanupStale, andnewRateLimitMiddlewarefactory live once;RateLimitMiddlewareandTokenRateLimitMiddlewarebecome thin adapters (each ~10 lines) that supply a key extractor, log attribute, and message stringsTest plan
make test— all unit tests pass (147 in the auth/http package)make lint— no issues🤖 Generated with Claude Code