refactor(transit): improve security, atomicity, and validation rules#89
Merged
refactor(transit): improve security, atomicity, and validation rules#89
Conversation
Enhance transit key security by implementing secure memory clearing, ensure atomic transit key creation using transactions, and refactor the validation layer to remove unused rules and add base64 validation. - transit: Add `Destroy()` method to `EncryptedBlob` for secure zeroing of plaintext data and update `DecryptHandler` to use it. - transit: Add version validation to `NewEncryptedBlob` to ensure it is greater than 0. - transit: Wrap `Create` operation in `TransitKeyUseCase` within a database transaction for atomicity. - validation: Remove unused `PasswordStrength`, `Email`, and `NoWhitespace` rules to simplify the package. - validation: Add `Base64` validation rule with corresponding unit tests. - validation: Update tests to reflect the removal of unused rules and add coverage for new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance transit key security by implementing secure memory clearing, ensure atomic transit key creation using transactions, and refactor the validation layer to remove unused rules and add base64 validation.
Destroy()method toEncryptedBlobfor secure zeroing of plaintext data and updateDecryptHandlerto use it.NewEncryptedBlobto ensure it is greater than 0.Createoperation inTransitKeyUseCasewithin a database transaction for atomicity.PasswordStrength,Email, andNoWhitespacerules to simplify the package.Base64validation rule with corresponding unit tests.