fix: updated rolecount.py to be more reflected of our current roles #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideUpdated rolecount.py to align with current server roles by overhauling the DE/WM, distro, language, and editor role lists, renaming variables and menu options, and inserting new roles and comments. Class diagram for updated role category variables in rolecount.pyclassDiagram
class RoleCountCog {
- des_ids: list
- distro_ids: list
- lang_ids: list
- editor_ids: list
- vanity_ids: list
- role_categories: dict
__init__(bot: Tux)
}
RoleCountCog : des_ids --> "DE/WM roles"
RoleCountCog : distro_ids --> "Distro roles"
RoleCountCog : lang_ids --> "Language roles"
RoleCountCog : editor_ids --> "Editor roles"
RoleCountCog : vanity_ids --> "Vanity roles"
RoleCountCog : role_categories --> "Category mapping"
Class diagram for role category menu option changesclassDiagram
class RoleCategoryMenu {
+ Distro: ds
+ Language: lg
+ DE/WM: de
+ Editors: edit
+ Vanity: vanity
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @cherryl1k - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `tux/cogs/guild/rolecount.py:133` </location>
<code_context>
[1187804435578093690, "_ed"],
- [1189236454153527367, "_gecko"],
- [1189236400571301958, "_chromium"],
+ [1392616344075243570, "_Cursor"],
+ [1367199970587050035, "_Zed"],
]
</code_context>
<issue_to_address>
Role name '_Cursor' uses uppercase; consider consistency.
Rename '_Cursor' to '_cursor' for consistency with other role names and to prevent case sensitivity issues.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| [1187804435578093690, "_ed"], | ||
| [1189236454153527367, "_gecko"], | ||
| [1189236400571301958, "_chromium"], | ||
| [1392616344075243570, "_Cursor"], |
Contributor
There was a problem hiding this comment.
nitpick: Role name '_Cursor' uses uppercase; consider consistency.
Rename '_Cursor' to '_cursor' for consistency with other role names and to prevent case sensitivity issues.
Deploying tux with
|
| Latest commit: |
9ea2c21
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0cf7cac4.tux-afh.pages.dev |
| Branch Preview URL: | https://rolecount-update.tux-afh.pages.dev |
electron271
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
========================================
+ Coverage 9.57% 9.63% +0.05%
========================================
Files 123 123
Lines 10415 10415
Branches 1279 1279
========================================
+ Hits 997 1003 +6
+ Misses 9316 9308 -8
- Partials 102 104 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
electron271
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates rolecount.py to be more reflective of our current roles (also added some comments)
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.
Additional Information
This will need to be tested in the main server before it can be merged
Summary by Sourcery
Update rolecount.py to reflect current guild roles and streamline role categories
Enhancements: