-
-
Notifications
You must be signed in to change notification settings - Fork 41
565 add poll ban #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
565 add poll ban #567
+249
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegrate with polls next.
Closed
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @FluxC0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving the
is_pollbannedmethod to a shared utility or base class to avoid code duplication betweenPollBanandPollUnbanclasses. - The comment in
on_reaction_addabout the bot 'freaking out' suggests an underlying issue with reaction removal. This should be investigated and addressed properly rather than just leaving a comment.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 3 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
this is just part of discord rate limiting, at the end of the day the reactions are still removed
Contributor
Author
|
yeah, those changes make sense. i felt as if it was a little unprofessional, but i didnt know what to change it to. thank you for addressing my note. |
electron271
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates the pollban command, which can prevent someone from making polls using tux. Fixes #565 .
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
[ V] I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
I used pollban on myself to make sure the command processed, and then tested making a poll afterwards to ensure that the ban works. Then, i unbanned myself and tested making polls afterward.
Summary by Sourcery
Add new commands 'pollban' and 'pollunban' to manage user permissions for creating polls. Implement checks to enforce poll bans and update documentation to reflect these changes.
New Features:
Enhancements:
Documentation: