-
-
Notifications
You must be signed in to change notification settings - Fork 42
Add dynamic versioning and remove single-source #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Merging to
|
Reviewer's Guide by SourceryThis pull request introduces dynamic versioning using the Updated class diagram for tux packageclassDiagram
class tux {
+__version__: str
}
note for tux "Version is now dynamically generated using poetry-dynamic-versioning"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @electron271 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
version = "0.1.0"instead ofversion = "0.0.0"inpyproject.tomlto better reflect the project's maturity. - It might be helpful to add a comment explaining why
single-sourcewas removed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…ynamic versioning
Description
auto generates version based on this, also removes single-source as its broken with this (and also not needed)
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
Tested with different branches
Screenshots (if applicable)
Please add screenshots to help explain your changes.
Additional Information
Please add any other information that is important to this PR.
Summary by Sourcery
Implement dynamic versioning for the project using poetry-dynamic-versioning and remove the single-source dependency
New Features:
Enhancements:
Chores: