make-Frame.buf-pointers-optional#29
Merged
kristoff-it merged 1 commit intoallyourcodebase:mainfrom Mar 23, 2026
Merged
Conversation
Member
|
Yes that's correct, buf can be null for both frames and packets to indicate that the frame/packet points at data that is not "owned" and that should not be freed when unreferencing the packet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if I'm abusing / misunderstanding the API.
I wasn't able to find a way to learn which of the 8 buf pointers are null given they are not optional.
This allows users to perform null checks so they can know which elements of buf are valid.