Supports PHP 8+ #75
Supports PHP 8+ #75
Conversation
MortalFlesh
force-pushed
the
feature/add-fixers-for-php8
branch
2 times, most recently
from
bfe7492 to
6ef593a
Compare
| $services->set(PhpdocToPropertyTypeFixer::class); | ||
| $services->set(PropertyTypeHintSniff::class); |
There was a problem hiding this comment.
They do the same? (Also the other two below). If so, I'd choose one, preferably the PhpCsFixer.
They sometimes do different adjustments and makes unsolvable conflict. Also any fixer slows the execution down, so if they don't adds a value, we should not be using them.
There was a problem hiding this comment.
Slevomat type hint sniffs handles superfluous annotations - I could not figure out how to remove them otherwise.
| "require": { | ||
| "php": "^7.3 || ^8.0", | ||
| "friendsofphp/php-cs-fixer": "^3.0", | ||
| "friendsofphp/php-cs-fixer": "dev-feature/fix-union-types-in-phpdocs as 3.8.0", |
There was a problem hiding this comment.
As we discussed, this will make it not installable without copying repositories block to every composer.json using lmc/coding-standard 😬
ecs.php
Outdated
| ] | ||
| ); | ||
|
|
||
| $parameters->set(Option::PARALLEL, true); |
There was a problem hiding this comment.
@MortalFlesh is this necessary? symplify/easy-coding-standard:^10 seems to enable this by default as well :)
MortalFlesh
force-pushed
the
feature/add-fixers-for-php8
branch
from
566f56d to
834ccdf
Compare
MortalFlesh
force-pushed
the
feature/add-fixers-for-php8
branch
3 times, most recently
from
884e9df to
d06acf6
Compare
MortalFlesh
force-pushed
the
feature/add-fixers-for-php8
branch
from
d06acf6 to
79a2ec4
Compare
4 participants
No description provided.