Returns error in case api response contains 'errors' key#179
Merged
Conversation
|
MarcAntoineGautier
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Widget is based on
POST v2/payments/eligibilityresponse to define its behavior.Most of the time, eligibility response in case of error is constructed with a property
error_code.In the widget code, we explicitly covered this case with
But there is a specific scenario in which the API respond with a error that does not contains

error_code, soit was not correctly catched in the widgets's code, and so the widget was blocked in "PENDING" state
This behavior can be reproduced locally by configuring the widget this way in
basic.html(from the master branch) :Which corresponds to calling
POST v2/payments/eligibilitywith the payload :Then, you'll notice the API response is :
Now, this PR fixes this behavior by adding a condition to the previous one :
And now, the widget is correctly hidden because of the eligibility error
