Merged
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves accessibility by fixing focus indicators on focusable elements in the widget. It removes the outline: none CSS property that was hiding focus indicators and replaces it with visible outlines that respect the UI theme.
- Removes
outline: nonefrom modal and widget button elements - Adds orange focus outline for default theme and black outline for monochrome theme
- Updates example file to use correct CSS file reference
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/Modal/Modal.module.css | Replaces hidden outline with visible orange focus indicator |
| src/Widgets/PaymentPlans/index.tsx | Adds monochrome class to support theme-aware focus styles |
| src/Widgets/PaymentPlans/PaymentPlans.module.css | Implements theme-aware focus indicators for widget buttons |
| examples/multiple.html | Updates CSS file reference from UMD to standard build |
FranceBe
changed the title
MarcAntoineGautier
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MXP-3259
Remove the
outline: none;css property on focusable items,Replace it with visible outline based on the monochrome property to respect the UI Theme of the widget.
Before :
After:
