chore(accessibility): Fix RGAA requirements#184
Merged
MarcAntoineGautier merged 4 commits intomasterfrom Aug 18, 2025
Merged
Conversation
* chore(rgaa): replace div role button with real button * chore(rgaa): fix code to match rgaa requirements * chore(rgaa): add jest-axe to test accessibility * chore(crowdin): update translations from crowdin * chore(doc): remove md file to use notion page instead * chore(en): fix hard coded french message to ensure full intl compatibility -wip * fix test --------- Co-authored-by: Marc-Antoine Gautier <marc-antoine.gautier@getalma.eu>
MarcAntoineGautier
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant accessibility improvements and minor visual refinements to the
EligibilityModaland related payment plan components. The changes focus on enhancing keyboard navigation, providing better screen reader support, and ensuring compliance with accessibility standards (such as RGAA). Additionally, several CSS adjustments improve responsiveness and consistency in font sizing.Accessibility improvements:
EligibilityPlansButtons,Info,Schedule) for improved screen reader navigation and semantics. Also introduced skip links for quick access to key sections. (src/Widgets/EligibilityModal/index.tsx[1] [2] [3];src/Widgets/EligibilityModal/components/EligibilityPlansButtons/index.tsx[4] [5] [6];src/Widgets/EligibilityModal/components/Info/index.tsx[7];src/Widgets/EligibilityModal/components/Schedule/index.tsx[8]src/Widgets/EligibilityModal/components/EligibilityPlansButtons/EligibilityPlansButtons.module.css[1];src/Widgets/PaymentPlans/PaymentPlans.module.css[2] [3]jest-axeto ensure no violations and proper keyboard navigation. (src/Widgets/EligibilityModal/__tests__/Accessibility.test.tsx[1];package.json[2] [3]Visual and style updates:
remunits for better scaling and zoom support. (src/Widgets/EligibilityModal/EligibilityModal.module.css[1];src/Widgets/EligibilityModal/components/EligibilityPlansButtons/EligibilityPlansButtons.module.css[2];src/Widgets/EligibilityModal/components/Info/Info.module.css[3];src/Widgets/EligibilityModal/components/Title/Title.module.css[4];src/Widgets/PaymentPlans/PaymentPlans.module.css[5] [6]src/Widgets/PaymentPlans/PaymentPlans.module.csssrc/Widgets/PaymentPlans/PaymentPlans.module.cssR57-R90)Other minor changes:
examples/multiple.htmlexamples/multiple.htmlL9-R9)These changes collectively make the modal experience more accessible and visually consistent for all users.