Skip to content

Chore/rgaa remaining issues#189

Merged
FranceBe merged 13 commits intomasterfrom
chore/rgaa-remaining-issues
Aug 29, 2025
Merged

Chore/rgaa remaining issues#189
FranceBe merged 13 commits intomasterfrom
chore/rgaa-remaining-issues

Conversation

@FranceBe
Copy link
Copy Markdown
Contributor

@FranceBe FranceBe commented Aug 29, 2025

Fixes MXP-3236

Accessibility improvements : (see each commit for an easier review)

  • Update the gray colors for a better contrast, based on recommendation from RGAA Audit
  • Set minimum transition delay to 1sec to avoid animation that is too fast and remove the limit to 5 sec as it did not make sense with the RGAA requirements
  • Automatic animation was not working anymore due to an infinite loop of re-renders from a wrongly configured dependency in a useEffect -> This PR fixes this behavior
  • Allow user to stop animation by hovering a plan button or selecting it from keyboard + add tests for useButtonAnimation hook
  • Automatically stop animation after each plan has been highlighted once (no infinite animation loop)
  • Small refactor of the realTransitionTime function to be clearer
  • Add missing aria attributes in SVG & modal
  • Improve focus & focus-visible css to match our design system
  • Add aria-describedby so screen reader can read the content of the "Info" section + improve the Schedule session as well to be correctly focused and read by screen readers
  • Update documentation to match new RGAA requirements states for the project
  • Fix unused import from src/Widgets/EligibilityModal/index.tsx as TotalBlock has been moved directly into the component Schedule for consistence with screen reading information
  • Dedicated hook for Animation instruction that are announced for screen readers + tests

@FranceBe FranceBe enabled auto-merge (squash) August 29, 2025 13:54
Comment thread src/Widgets/PaymentPlans/index.tsx
@FranceBe FranceBe disabled auto-merge August 29, 2025 13:59
@sonarqubecloud
Copy link
Copy Markdown

@FranceBe FranceBe merged commit aeb4ab8 into master Aug 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants