Merged
Conversation
Contributor
Author
|
Maybe, there should be something added in the readme, like an example docker-compose.yml. |
almarklein
reviewed
May 31, 2022
Owner
There was a problem hiding this comment.
Really nice to automate the process like this!
If I understand correctly, we still need a version where the authentication is either fully open, or password-based. Because now any attempt to auth would be rejected, right?
edit: you or I could do that in a later PR. This is a great start anyways!
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #146
It is currently configured to build and push a dockerimage on every tag.