Consider using `corepc-types`

[tcharding]

We just cut corepc-types v0.9.0 which supports all documented RPC methods and is tested for versions 17 - 29. You guys could use it and remove types.rs if you wanted to, theoretically without too much effort.

[storopoli]

Amazing. types.rs were created back in 28 when we wanted to use the submitpackage and corepc-types (had another name even back then) did not support it yet.
Will work on a fix, thanks for the suggestion. I need to keep up with the corepc development.

[tcharding]

No sweat, hope you like it.

[storopoli]

I'm in the midst of it. Two things I've realized:

• At least one type is missing. There are still tons to go. I think I've ported 10%.
• I'll need (and should have done this earlier) to version control feature gating functionality related to bitcoin core versions. Similar to how corepc-types do. Will start with v29.

Will open a PR and ask you to take a look if you don't mind. I'll probably open PRs in corepc-types for the missing types as well.

[storopoli]

Hey @tcharding check please #59 (draft) and

• fix!(types): v24/v28 fixes rust-bitcoin/corepc#375
• feat(types): add new types for inputs/outputs and options rust-bitcoin/corepc#376

[storopoli]

@tcharding thanks for reviewing the PRs and tagging the versions. We have -1K LoC to directly maintain (note that this was duplicated work from corepc) and any bugs or features I'll upstream to corepc.

[tcharding]

Mad, that is a win.