-
Notifications
You must be signed in to change notification settings - Fork 4
feat!: migrate to corepc-types
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storopoli
commented
Oct 2, 2025
storopoli
commented
Oct 2, 2025
storopoli
commented
Oct 2, 2025
895acaa to
22f66aa
Compare
22f66aa to
e06869e
Compare
3991ca0 to
591f9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still WIP since it needs some proper changes backported to
corepc-types.See the comments below or grep for
FIXME, additionally all the remaining types intypes.rsneeds to be ported tocorepc-typesas well.This PR also introduces feature-gating in sync with Bitcoin core versions starting from v29.0.
Type of Change
Notes to Reviewers
Blocked 🪨 by:
Checklist
Related Issues
Closes #48