Skip to content

Conversation

@storopoli
Copy link
Member

@storopoli storopoli commented Oct 2, 2025

Description

Still WIP since it needs some proper changes backported to corepc-types.
See the comments below or grep for FIXME, additionally all the remaining types in types.rs needs to be ported to corepc-types as well.

This PR also introduces feature-gating in sync with Bitcoin core versions starting from v29.0.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Blocked 🪨 by:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Closes #48

@storopoli storopoli marked this pull request as draft October 2, 2025 15:16
@storopoli storopoli force-pushed the corepc-types branch 2 times, most recently from 895acaa to 22f66aa Compare October 2, 2025 16:24
@storopoli storopoli marked this pull request as ready for review October 10, 2025 16:55
@storopoli storopoli merged commit 0033ca3 into main Oct 10, 2025
10 checks passed
@storopoli storopoli deleted the corepc-types branch October 10, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using corepc-types

2 participants