Skip to content

Propose accessibility fixes for enhanceSelectElement #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oscarduignan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Propose accessibility fixes for enhanceSelectElement #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@ accessibleAutocomplete.enhanceSelectElement = (configurationOptions) => {
configurationOptions.source = availableOptions.map(option => option.textContent || option.innerText)
}
configurationOptions.onConfirm = configurationOptions.onConfirm || (query => {
// so that we don't retain previous selection
configurationOptions.selectElement.value = '';

// for example, given an autocomplete of locations without auto select
// 1. user enters "United"
// 2. user clicks "United States" by mistake
// 3. user edits the field with "United Kingdom" but does not select the option
// 4. user submits the form
// 5. server receives "United States"

const requestedOption = [].filter.call(configurationOptions.selectElement.options, option => (option.textContent || option.innerText) === query)[0]
if (requestedOption) { requestedOption.selected = true }
})
Expand Down Expand Up @@ -55,6 +65,16 @@ accessibleAutocomplete.enhanceSelectElement = (configurationOptions) => {

configurationOptions.selectElement.style.display = 'none'
configurationOptions.selectElement.id = configurationOptions.selectElement.id + '-select'

// so that screen readers will announce hint and error when interacting with the new input
const autocompleteInput = element.getElementById(configurationOptions.id);
const hintAndErrorLinks = configurationOptions.selectElement.getAttribute('aria-describedby')
if (autocompleteInput && hintAndErrorLinks !== null) {
autocompleteInput.setAttribute(
'aria-describedby',
hintAndErrorLinks + ' ' + autocompleteInput.getAttribute('aria-describedby')
)
}
}

export default accessibleAutocomplete