fix: handle bad response format #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guifry
force-pushed
the
guilhemf/fix/handle-bad-response-format
branch
3 times, most recently
from
51580b1 to
68faff6
Compare
test(client): add unit tests for bad repsonse format handling chore(client): created mock expressjs app for testing timeouts and bad response formats
guifry
force-pushed
the
guilhemf/fix/handle-bad-response-format
branch
from
68faff6 to
632d430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the API ever returns a response the client doesn't know how to handle, then the client should default the consents to
REJECTED.I've also added a mock API with express designed for this purpose, as well as testing timeouts.
Useful for manual debugging.