Skip to content

Comments

Add page titles for group pages#1049

Merged
DavidBiddle merged 1 commit intomainfrom
ldeb-add-page-titles
Apr 4, 2024
Merged

Add page titles for group pages#1049
DavidBiddle merged 1 commit intomainfrom
ldeb-add-page-titles

Conversation

@lfdebrux
Copy link
Member

What problem does this pull request solve?

Some of the pages for the groups feature were missing page titles, this commit makes sure that each page has a unique title.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux force-pushed the ldeb-add-page-titles branch 2 times, most recently from a1b7b66 to 982df3b Compare March 28, 2024 09:45
Some of the pages for the groups feature were missing page titles, this
commit makes sure that each page has a unique title.
@DavidBiddle DavidBiddle force-pushed the ldeb-add-page-titles branch from 982df3b to 7f7762e Compare April 4, 2024 12:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidBiddle DavidBiddle merged commit 5b027fc into main Apr 4, 2024
@DavidBiddle DavidBiddle deleted the ldeb-add-page-titles branch April 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants