Render separate view for making draft of archived form live#1067
Merged
stephencdaly merged 1 commit intomainfrom Apr 3, 2024
Merged
Conversation
We will have different content for the confirm page for making the draft of an archived form live. Render a separate view for this - `make_archived_draft_live.html.erb`. This view currently duplicates the content for making the draft of a live form live, and the content will need to be updated when it is ready. This will render the same content regardless of whether the form is in `archived` or `archived_with_draft` state. The form will only transition to `archived_with_draft` state if edits are made before making the draft live. We have a separate route and controller for making the form live again without making a draft, so the content for that is separate.
stephencdaly
force-pushed
the
1433-render-make-archive-live-page-for-making-archive-draft-live
branch
from
f06df40 to
b585d8d
Compare
|
chao-xian
approved these changes
Apr 3, 2024
stephencdaly
deleted the
1433-render-make-archive-live-page-for-making-archive-draft-live
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/UVCBeTs8/1433-allow-user-to-create-a-draft-for-an-archived-form
We will have different content for the confirm page for making the draft of an archived form live. Render a separate view for this -
make_archived_draft_live.html.erb. This view currently duplicates the content for making the draft of a live form live, and the content will need to be updated when it is ready.This will render the same content regardless of whether the form is in
archivedorarchived_with_draftstate. The form will only transition toarchived_with_draftstate if edits are made before making the draft live. We have a separate route and controller for making the form live again without making a draft, so the content for that is separate.Things to consider when reviewing