Merged
Conversation
hannahkc
reviewed
Apr 5, 2024
DavidBiddle
approved these changes
Apr 5, 2024
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
Code looks great, works on my machine, and good content too 💯
To show the list of users within a group as shown in the designs, we need a new route. A new subresrouce is created with only the index. It's called group_members to follow the convention of group_forms. "Members" is the content designers choice for users belonging to a group.
A new view and specs are added following the designs for listing members of a group. The action buttons and button to add new members hasn't been added. They will be added in later commits.
Add a new controller for the group_members resource. The only action is to list the members of the Group.
Only users who are members of a Group should be able to view the list of members.
Add a link to the Group#show page to the new page to list members. Use the list component to contain the change group name and group members links. Using the govuk-button group would layout the links horizontally on desktop and stack them on mobile. Instead, we use a list, which follows the way we do it with the options when editing pages.
Add a new feature test for showing the the members of a group.
Co-authored-by: hannahkc <hannah.cooper@digital.cabinet-office.gov.uk>
thomasiles
force-pushed
the
add-users-screen
branch
from
a61cc86 to
4c28c2f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new page to show members of a Group
Trello card: https://trello.com/c/o7SAFAWi/1401-add-screens-for-managing-existing-users-in-groups
This PR starts the work for managing members of a group.
It only tackles the basic journey of showing the members of a group. This is what members of a group with the role editor will see. Other members, group admins, org admins and super admins will all have options for adding and removing users fro the group.
When the group doesn't have any members, I've added some new content (which can be changed). I think this screen won't happen often but super admins and org admins might see it if all members are removed from a group:
Link from the group page:
Things to consider when reviewing