Skip to content

Add feature flag for branch routing#1119

Merged
lfdebrux merged 2 commits intomainfrom
ldeb-add-feature-flag-branching
Oct 31, 2024
Merged

Add feature flag for branch routing#1119
lfdebrux merged 2 commits intomainfrom
ldeb-add-feature-flag-branching

Conversation

@lfdebrux
Copy link
Copy Markdown
Member

What problem does this pull request solve?

Trello card: https://trello.com/c/8TrmJ7Ou/1960-add-feature-flag-for-branching-to-forms-admin

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

@lfdebrux lfdebrux force-pushed the ldeb-add-feature-flag-branching branch from d1506d2 to f6b00d3 Compare October 30, 2024 15:25
@lfdebrux lfdebrux force-pushed the ldeb-add-feature-flag-branching branch from f6b00d3 to dd19d02 Compare October 30, 2024 15:30
@lfdebrux lfdebrux merged commit 2c06fe4 into main Oct 31, 2024
@lfdebrux lfdebrux deleted the ldeb-add-feature-flag-branching branch October 31, 2024 10:08
thomasiles added a commit that referenced this pull request Jan 30, 2025
…branching"

This reverts commit 2c06fe4, reversing
changes made to e93aa4f.
thomasiles added a commit that referenced this pull request Jan 30, 2025
…ure-flag

Revert "Merge pull request #1119 from alphagov/ldeb-add-feature-flag-branching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants