Skip to content

Update references to the forms-runner ECS task for queue alerts#2002

Merged
stephencdaly merged 1 commit intomainfrom
update-task-name-in-jobs
Mar 2, 2026
Merged

Update references to the forms-runner ECS task for queue alerts#2002
stephencdaly merged 1 commit intomainfrom
update-task-name-in-jobs

Conversation

@stephencdaly
Copy link
Contributor

What problem does this pull request solve?

Solid Queue now runs in the forms-runner-queue-worker ECS task. Update alarm descriptions to reflect this change.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

Copilot AI review requested due to automatic review settings February 26, 2026 13:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CloudWatch alarm descriptions in the Forms health/alerts Terraform to reflect that Solid Queue now runs in the forms-runner-queue-worker ECS task, so on-call runbooks point responders to the correct service.

Changes:

  • Replace references to the forms-runner ECS task with forms-runner-queue-worker in multiple alarm descriptions.
  • Update “NEXT STEPS” instructions to restart the forms-runner-queue-worker ECS tasks where applicable.
  • Minor reflowing of alarm description text for readability.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
infra/deployments/forms/health/alerts/send-submission-job-failures.tf Updates alarm description to reference the queue-worker ECS task.
infra/deployments/forms/health/alerts/schedule-daily-batch-deliveries-job-not-run.tf Updates alarm/runbook text to reference restarting the queue-worker ECS tasks.
infra/deployments/forms/health/alerts/receive-submission-deliveries-job-not-run.tf Updates alarm/runbook text to reference queue-worker ECS tasks.
infra/deployments/forms/health/alerts/receive-submission-bounces-and-complaints-job-not-run.tf Updates alarm/runbook text to reference queue-worker ECS tasks.
infra/deployments/forms/health/alerts/delete-submissions-job-not-run.tf Updates alarm/runbook text to reference queue-worker ECS tasks (with a line wrap).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Solid Queue now runs in the forms-runner-queue-worker ECS task.
Update alarm descriptions to reflect this change.
@stephencdaly stephencdaly force-pushed the update-task-name-in-jobs branch from 52123b6 to f0c3d02 Compare February 26, 2026 14:08
@stephencdaly stephencdaly added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 343dcc4 Mar 2, 2026
17 checks passed
@stephencdaly stephencdaly deleted the update-task-name-in-jobs branch March 2, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants