Conversation
For sending weekly submission batches, we need to know the start date for the batch to include in the email content and when handling bounced emails. For daily batch deliveries, all submissions were on the same day so we could use the created_at for any of the submissions. This column is nullable and will only be set for `daily` and `weekly` deliveries. For `immediate` deliveries it will be null.
We've added batch_begin_at so that we know the start datetime of weekly batch deliveries, but for consistency also set it for daily batch deliveries.
Rather than get the date off a submission, use the batch_begin_at from the delivery. This makes it easier to re-use the job for sending weekly batches.
|
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
2 participants
What problem does this pull request solve?
Trello card: https://trello.com/c/v2LQDGgq
For sending weekly submission batches, we need to know the start date for the batch to include in the email content and when handling bounced emails.
For daily batch deliveries, all submissions were on the same day so we could use the created_at for any of the submissions.
Store the time the batch starts on the delivery in a new
batch_begin_atcolumn so this is easily retrievable.This column is nullable and will only be set for
dailyandweeklydeliveries. Forimmediatedeliveries it will be null.Things to consider when reviewing