Skip to content

create a valid startup command for both new worker types `api-worker-…#4792

Open
rparke wants to merge 1 commit intomainfrom
rp-add-startup-commands-for-new-workers
Open

create a valid startup command for both new worker types `api-worker-…#4792
rparke wants to merge 1 commit intomainfrom
rp-add-startup-commands-for-new-workers

Conversation

@rparke
Copy link
Copy Markdown
Contributor

@rparke rparke commented Mar 27, 2026

…jobs-saveandapi-worker-jobs-save-documents`

when adding the new queues and new worker types https://github.com/alphagov/notifications-aws/pull/2884 we need to ensure that new workers can startup properly without any issues. This means temporarily configuring each new worker type to take tasks from existing queues, before upgrading notifications-api #4784 to populate, and take messages off the new queues.

TODO:

@risicle
Copy link
Copy Markdown
Member

risicle commented Mar 27, 2026

My only concern with this is there will be a phase of the rollout where the jobs worker(s) will be able to create notifications at 3x the current rate (3 pools cooperating). Remember, the main reason for limitations on numbers of jobs workers is to throttle this rate.

Hopefully that will be a short period and this won't be a problem?

@rparke
Copy link
Copy Markdown
Contributor Author

rparke commented Mar 27, 2026

My only concern with this is there will be a phase of the rollout where the jobs worker(s) will be able to create notifications at 3x the current rate (3 pools cooperating). Remember, the main reason for limitations on numbers of jobs workers is to throttle this rate.

Hopefully that will be a short period and this won't be a problem?

That's basically my assumption. The alternative is maybe that we initially initialise those workers to do nothing? So they can start up but nothing happens

@risicle
Copy link
Copy Markdown
Member

risicle commented Mar 27, 2026

Mnah we probably want to them to do something in case somehow we break the original. It's probably fine, let's just not hang around when we do it.

@rparke
Copy link
Copy Markdown
Contributor Author

rparke commented Mar 27, 2026

Mnah we probably want to them to do something in case somehow we break the original. It's probably fine, let's just not hang around when we do it.

Works for me. I guess queue all 3 releases up to go as quickly as posible

@rparke rparke force-pushed the rp-add-startup-commands-for-new-workers branch from 155d246 to 3064e65 Compare April 2, 2026 11:08
…jobs-save` and `api-worker-jobs-save-documents`

when adding the new queues and new worker types alphagov/notifications-aws#2884 we need to ensure that new workers can startup properly without any issues. This means temporarily configuring each new worker type to take tasks from existing queues, before upgrading `notifications-api` #4784 to populate, and take messages off the new queues.
@rparke rparke force-pushed the rp-add-startup-commands-for-new-workers branch from 638505c to 80c16ff Compare April 2, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants