Adjust the times that the we check for letters pending virus check#4852
Merged
Conversation
In rare cases (for a particular service where we know the letters don't get processed well) we see letters that still haven't gone through the sanitisation process with the number of retries we already do. While we know the "real fix" is to upgrade PyMyPDF in template-preview, this will take some planning. For now, we increase the number of times we retry letters still pending virus check to try and ensure that every letters always end up in the created state.
spatel033
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare cases (for a particular service where we know the letters don't get processed well) we see letters that still haven't gone through the sanitisation process with the number of retries we already do.
While we know the "real fix" is to upgrade PyMyPDF in template-preview, this will take some planning. For now, we increase the number of times we retry letters still pending virus check to try and ensure that every letter always ends up in the created state.
Trello card