Update path to GOV.UK Frontend assets when using GOV.UK logo #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were pointing to the locations before the brand refresh, so the wrong favicon were showing. Includes the favicons in the header, as well as the Open Graph image. Paths to the assets when not using the GOV.UK logo were left untouched, as they are built from separate options.
romaricpascal
force-pushed
the
update-asset-path
branch
from
e063a74 to
f135f8c
Compare
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were pointing to the locations before the brand refresh, so the wrong favicon were showing. Includes the favicons in the header, as well as the Open Graph image.
Paths to the assets when not using the GOV.UK logo were left untouched, as they are built from separate options.
In action:
