Merged
Conversation
- update package-lock.json - include .njk files into assets - add extension and render functions to load in govuk components
- use renderer to create and parse nunjucks components
- add condition to only enable the extension if wanted - update example site with govuk component
- add condition to only enable the extension if wanted - update example site with govuk component
- add condition to only enable the extension if wanted - update example site with govuk component
- add unit tests for GovukTechDocs::CustomMethodMissingHandler
- unit tests to test the specific helper method class in the template context
- remove rubocop warning for testing specific error
- split the logic out more clearly so we can understand the rules
- update CHANGELOG.md
…e site test for more detailed testing - add test suite to confirm active header works correctly
# Conflicts: # CHANGELOG.md # package-lock.json
# Conflicts: # CHANGELOG.md # lib/govuk_tech_docs/version.rb # package-lock.json
# Conflicts: # CHANGELOG.md # lib/govuk_tech_docs/version.rb # package-lock.json # package.json # spec/features/integration_spec.rb
…ctive-tab Bugfix/issue 446 inconsistent active tab
# Conflicts: # CHANGELOG.md # lib/govuk_tech_docs/version.rb
Add option to use GOV.UK Design System components
Closed
# Conflicts: # CHANGELOG.md # govuk_tech_docs.gemspec
# Conflicts: # lib/govuk_tech_docs/version.rb
# Conflicts: # CHANGELOG.md # lib/govuk_tech_docs/version.rb
brucebolt
approved these changes
Apr 14, 2026
Member
brucebolt
left a comment
brucebolt
left a comment
There was a problem hiding this comment.
The changes look ok, but with a caveat I'm not familiar at all with nunjucks or implementing the Design System.
- raise error rather than return error as template string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #458