Add warning text extension#78
Merged
Merged
Conversation
Now you too can warn people as recommended by the GOV.UK Design System: https://design-system.service.gov.uk/components/warning-text/ All you have to do is include: `<%= warning_text('Look out!') %>` in your ERB content.
vixus0
force-pushed
the
add-warning-text-partial
branch
from
2e7cfe9 to
b650d31
Compare
|
When this feature goes live, we should also add documentation to https://tdt-documentation.london.cloudapps.digital/ 👌 |
tlwr
previously approved these changes
Mar 20, 2019
tlwr
dismissed
their stale review
It is not my place to approve this but I endorse it
jakubmiarka
approved these changes
Mar 20, 2019
Contributor
jakubmiarka
left a comment
jakubmiarka
left a comment
There was a problem hiding this comment.
Looks ok 👍 while #34 is being worked on
| font-size: 16px; | ||
| font-size: 1rem; | ||
| line-height: 1.25; | ||
| color: #0b0c0c; |
Contributor
There was a problem hiding this comment.
we should probably be using colours from the palette and other stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you too can warn people as recommended by the GOV.UK Design System:
https://design-system.service.gov.uk/components/warning-text/
All you have to do is include:
<%= warning_text('Look out!') %>inyour ERB content.