Skip to content

fixes #425#428

Closed
Legacywave1 wants to merge 1 commit into
alphaonelabs:mainfrom
Legacywave1:patch-1
Closed

fixes #425#428
Legacywave1 wants to merge 1 commit into
alphaonelabs:mainfrom
Legacywave1:patch-1

Conversation

@Legacywave1
Copy link
Copy Markdown
Contributor

@Legacywave1 Legacywave1 commented Apr 4, 2025

This is to solve the issue where if a user does not have their public profile set to public then they are not shown on the leaderboard.

Summary by CodeRabbit

  • New Features
    • Enhanced leaderboard displays now include only users with public profiles, ensuring that rankings across weekly, monthly, and global views feature users who have opted for visibility while continuing to exclude teachers.

This is to solve the issue where if a user does not have their public profile set to public then they are not shown on the leaderboard.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the leaderboard retrieval functionality in the application. The get_leaderboard function in web/utils.py has been modified so that the database queries for weekly, monthly, and global leaderboards now include an additional filter. The new condition ensures that only users with public profiles (user__profile__is_public=True) are included in the results, alongside the existing condition that excludes teachers.

Changes

File Change Summary
web/utils.py Updated the leaderboard queries (weekly, monthly, global) to add a filter that includes only users with public profiles (user__profile__is_public=True)

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant LB as get_leaderboard
    participant DB as Database

    C->>LB: Request leaderboard data
    LB->>DB: Execute query with filters: is_teacher == False<br/>and is_public == True
    DB-->>LB: Return filtered leaderboard entries
    LB-->>C: Return leaderboard data
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32ada90 and 22fcc16.

📒 Files selected for processing (1)
  • web/utils.py (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2025

🚨 Missing Open Issue Link

This pull request appears to not reference any open GitHub issue.

As per our workflow requirements, all PRs should address an existing open issue. This ensures:

  • Changes are properly tracked
  • Work is discussed before implementation
  • Code reviews are more focused

How to Fix This

Please link this PR to an existing open issue using one of these methods:

  1. Reference the issue in your PR description: "Fixes darkmode/about #123" or "Addresses darkmode/about #123"
  2. Use GitHub's interface to link the PR to an issue in the Development section
    - Look for the section that says "Development" on the right side of your PR
    - Click "Link an issue" or "Link issues"
    - Select the relevant issue(s)
  3. If no issue exists yet, please create one first
  4. If you linked to a closed issue, please link to an open issue instead

This PR will be automatically closed. Feel free to reopen it once you've linked it to an open issue or added appropriate labels.

Thank you for your contribution!

@github-actions github-actions Bot closed this Apr 4, 2025
@Legacywave1 Legacywave1 changed the title I have updated issue #425 fixes #425 Apr 4, 2025
@Legacywave1 Legacywave1 deleted the patch-1 branch April 4, 2025 11:54
@Legacywave1 Legacywave1 restored the patch-1 branch April 4, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant