Skip to content

Average rating rounded#560

Merged
A1L13N merged 12 commits into
alphaonelabs:mainfrom
meyyy03:average-rating-rounded
Aug 25, 2025
Merged

Average rating rounded#560
A1L13N merged 12 commits into
alphaonelabs:mainfrom
meyyy03:average-rating-rounded

Conversation

@meyyy03
Copy link
Copy Markdown
Contributor

@meyyy03 meyyy03 commented Apr 17, 2025

fix #554

Description
This PR fixes an issue where the course average rating was displayed with too many decimal places (e.g., 4.333333333333333). The average rating is now properly rounded to two decimal places.

Changes Made
Updated the average_rating property to round the result to 2 decimal points.

Before & After
Before: 4.333333333333333
After: 4.33

How to test
Open any course with reviews.
Confirm that the average rating is now shown with only two digits after the decimal.

Summary by CodeRabbit

  • Refactor
    • Improved the calculation of course average ratings for greater accuracy and consistency by leveraging database aggregation and rounding.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2025

"""

Walkthrough

The change updates the average_rating property of the Course model in web/models.py. The previous implementation manually calculated the average rating from related Review objects. The new implementation uses Django's ORM aggregation function Avg to compute the average rating directly in the database, rounds the result to two decimal places, and defaults to 0 if there are no reviews. This refactor simplifies the code and ensures the returned average is rounded as required.

Changes

File(s) Change Summary
web/models.py Refactored Course.average_rating property to use Django ORM's Avg aggregation and rounding.

Assessment against linked issues

Objective Addressed Explanation
Round average rating to two decimal places in course card display (#554)
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 268f0a2 and a91946f.

📒 Files selected for processing (1)
  • web/models.py (2 hunks)
🔇 Additional comments (1)
web/models.py (1)

10-10: Good addition of ORM aggregation import
Importing Avg from django.db.models is necessary for the new aggregation logic.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 17, 2025
Copy link
Copy Markdown
Contributor

@A1L13N A1L13N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run the pre-commit / lint

auto-merge was automatically disabled April 19, 2025 11:33

Head branch was pushed to by a user without write access

@meyyy03 meyyy03 force-pushed the average-rating-rounded branch from 60d62bb to 63b638d Compare April 19, 2025 11:33
@meyyy03 meyyy03 requested a review from A1L13N April 19, 2025 11:43
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63b638d and 55039cc.

📒 Files selected for processing (1)
  • web/models.py (2 hunks)
🔇 Additional comments (1)
web/models.py (1)

9-9: Add import for database-level aggregation
The Avg import is correctly added to support the new average_rating implementation using Django’s ORM aggregation function.

Comment thread web/models.py
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
web/models.py (1)

325-326: Efficient calculation with ORM aggregation and rounding.

The updated average_rating property uses Django's aggregate to compute the average rating, defaults to 0 when there are no reviews, casts to float, and rounds to two decimal places, improving readability and performance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55039cc and 1be4225.

📒 Files selected for processing (1)
  • web/models.py (2 hunks)
🔇 Additional comments (1)
web/models.py (1)

9-9: Import Avg from django.db.models.

This import is correctly placed and required for the new aggregation in average_rating.

Comment thread web/models.py
meyyy03 and others added 3 commits April 21, 2025 13:28
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 25, 2025
@A1L13N A1L13N enabled auto-merge April 25, 2025 15:49
auto-merge was automatically disabled May 28, 2025 08:11

Head branch was pushed to by a user without write access

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2025
@A1L13N A1L13N merged commit da6041d into alphaonelabs:main Aug 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Average Rating Not Rounded in Course Card Display

2 participants