Skip to content

Fix eraser tool to properly erase content instead of painting white in dark mode#652

Merged
A1L13N merged 2 commits into
mainfrom
copilot/fix-613
Aug 25, 2025
Merged

Fix eraser tool to properly erase content instead of painting white in dark mode#652
A1L13N merged 2 commits into
mainfrom
copilot/fix-613

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jul 11, 2025

Problem

The eraser tool in the Advanced Whiteboard was not functioning correctly in dark mode. Instead of removing drawn content, it was painting white lines over it, which became highly visible against the dark background. This made the eraser behave more like a white pen than an actual eraser.

Root Cause

The eraser implementation used ctx.strokeStyle = "#FFFFFF" to "erase" by painting white over content. While this approach worked in light mode (white background), it failed in dark mode where white lines became visible against the black background.

Solution

Replaced the color-based erasing with proper canvas erasing using globalCompositeOperation = 'destination-out'. This composite operation actually removes pixels from the canvas regardless of background color.

Changes Made

  1. Eraser tool logic - Changed from ctx.strokeStyle = "#FFFFFF" to ctx.globalCompositeOperation = 'destination-out'
  2. Tool switching - Updated tool selection handler to properly set composite operations when switching between tools
  3. Drawing tools - Ensured all other drawing tools explicitly reset to ctx.globalCompositeOperation = 'source-over'

Visual Demonstration

Before (Light Mode): Works correctly
Light mode whiteboard

Problem (Dark Mode): White eraser line is visible instead of erasing
Dark mode showing white eraser line

After Fix: The eraser now properly removes content in both light and dark modes without leaving visible marks.

Testing

  • ✅ Verified eraser removes content without visible traces in both modes
  • ✅ Confirmed pen, highlighter, and shape tools continue working correctly
  • ✅ Tested tool switching preserves correct composite operations
  • ✅ Django project builds and runs without errors

Fixes #613.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: A1L13N <193832434+A1L13N@users.noreply.github.com>
Copilot AI changed the title [WIP] Eraser Tool Draws in White Instead of Erasing on Dark Mode Whiteboard Fix eraser tool to properly erase content instead of painting white in dark mode Jul 11, 2025
Copilot AI requested a review from A1L13N July 11, 2025 06:56
@A1L13N A1L13N marked this pull request as ready for review August 25, 2025 01:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@A1L13N A1L13N merged commit 649b8d3 into main Aug 25, 2025
2 checks passed
@A1L13N A1L13N deleted the copilot/fix-613 branch August 25, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eraser Tool Draws in White Instead of Erasing on Dark Mode Whiteboard

2 participants