Add privacy checks for profile links in course detail page#705
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: A1L13N <193832434+A1L13N@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update course detail page layout and design
Add privacy checks for profile links in course detail page
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When viewing a course detail page, profile links were displayed for both teachers and students regardless of their privacy settings. Clicking on a link to a private profile would result in a 404 error, creating a poor user experience.
Solution
This PR adds privacy checks before displaying profile links in the course detail page:
Changes Made
Teacher Profile Link (lines 217-223)
{% if course.teacher.profile.is_profile_public %}before rendering the "View Profile" buttonStudent Profile Links in Enrollments Table (lines 852-858)
{% if enrollment.student.profile.is_profile_public %}before rendering the profile icon linkExample
Before: All users had "View Profile" links, even those with private profiles
After: Profile links only shown for public profiles
{% if course.teacher.profile.is_profile_public %} <a href="{% url 'public_profile' course.teacher.username %}"> <i class="fas fa-user mr-2"></i> View Profile </a> {% endif %}Related Issue
This is a subset of the changes from PR #622, specifically keeping only the course detail page modifications as requested.
Testing
is_profile_publicisFalseOriginal prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.