fix: Add Virtual Labs link to mobile navigation menu#789
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: alphaonelabs/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe visible label for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
web/templates/base.html
🧰 Additional context used
📓 Path-based instructions (3)
web/templates/**/*.html
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
web/templates/**/*.html: Format HTML/Django templates with djlint using 120-character line length
Use Tailwind CSS classes only in templates (no custom CSS or inline styles)
Include dark mode variants using the "dark:" prefix in templates
Ensure proper HTML structure and accessibility in templates
Follow project color scheme in templates (teal-300, gray-600, green-600, yellow-600, red-600)
Files:
web/templates/base.html
**/*.{html,htm}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{html,htm}: Always use Tailwind CSS classes for styling HTML elements
Never use inline styles
Follow the project's color scheme using Tailwind's color classes (Primary: teal-300, Secondary: gray-600, Success: green-600, Warning: yellow-600, Danger: red-600, Dark mode variants using dark: prefix)
Use Tailwind container classes: container mx-auto px-4 for containers
Use Tailwind card classes: bg-white dark:bg-gray-800 rounded-lg shadow-lg for cards
Use Tailwind form input classes: w-full px-4 py-2 border border-gray-300 dark:border-gray-600 rounded-lg focus:ring-2 focus:ring-blue-500 for form inputs
Use Tailwind form label classes: block text-sm font-medium text-gray-700 dark:text-gray-300 for form labels
Use Tailwind primary button classes: bg-teal-300 hover:bg-teal-400 text-white px-6 py-2 rounded-lg transition duration-200
Use Tailwind secondary button classes: bg-gray-100 hover:bg-gray-200 dark:bg-gray-700 text-gray-700 dark:text-gray-300
Use Tailwind heading classes: text-2xl font-bold (adjust size as needed) for headings
Use Tailwind body text classes: text-gray-600 dark:text-gray-300 for body text
Use Tailwind link classes: text-blue-600 hover:text-blue-800 dark:text-blue-400 for links
Use flex and grid for layouts
Use consistent spacing with gap-{size} and space-{y|x}-{size} Tailwind classes
Use responsive design with Tailwind prefixes: sm:, md:, lg:, xl:
Always include dark mode alternatives using dark: prefix for elements
Use dark:bg-gray-800 for dark mode card backgrounds
Use dark:text-gray-300 for dark mode text
Use proper heading hierarchy for accessibility
Include proper ARIA labels where needed for accessibility
Ensure sufficient color contrast for accessibility
Add hover/focus states for interactive elements
Files:
web/templates/base.html
**/*.{html,htm,css}
📄 CodeRabbit inference engine (AGENTS.md)
Never use custom CSS classes
Files:
web/templates/base.html
🧠 Learnings (1)
📓 Common learnings
Learnt from: Abhishek-Punhani
Repo: alphaonelabs/alphaonelabs-education-website PR: 337
File: web/templates/courses/detail.html:1506-1560
Timestamp: 2025-04-07T11:33:41.277Z
Learning: For the alphaonelabs-education-website project, the team prefers to keep PRs focused and manageable in size. Additional enhancements like accessibility improvements should be addressed in separate follow-up issues rather than expanding the scope of an existing PR.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Tests
🔇 Additional comments (1)
web/templates/base.html (1)
701-701: LGTM! Label now matches desktop navigation.The rename from "Trackers" to "Progress Trackers" correctly achieves feature parity with the desktop RESOURCES dropdown (Line 293).
|
@A1L13N Can you review this? |
🚚 This Repository Is MovingHi @KhushamBansal, thank you for your contribution! We are in the process of migrating most of the logic from this repository to our new repository: alphaonelabs/learn. What this means for your PRPlease do not merge or continue work here. Instead:
This PR has been automatically closed. Once you have opened your PR in the new repository, feel free to reference it here. Thank you for your understanding and continued support! 🙏 |
1 participant
Related issues
Fixes #788
Checklist
Purpose: Fix mobile navigation parity by adding the missing "Virtual Labs" link to the RESOURCES accordion and clarify label text.
Key changes:
Impact:
Other notes: