Skip to content

fix: prioritize run_id when provided #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JovihanniCasenas merged 1 commit into from
May 26, 2026
Merged

fix: prioritize run_id when provided #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,26 +429,28 @@ func (a *appctx) isRunCancelled(runID string, commitSha string) bool {
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
defer cancel()

stmt := spanner.Statement{
SQL: fmt.Sprintf(`SELECT run_id FROM %s
WHERE (run_id = @run_id OR commit_sha = @commit_sha)
AND status = 'closed'
LIMIT 1`, spannercanceltable),
Params: map[string]interface{}{
"run_id": runID,
"commit_sha": commitSha,
},
var stmt spanner.Statement
if runID != "" {
stmt = spanner.Statement{
SQL: fmt.Sprintf(`SELECT run_id FROM %s WHERE run_id = @run_id AND status = 'closed' LIMIT 1`, spannercanceltable),
Params: map[string]interface{}{
"run_id": runID,
},
}
} else {
stmt = spanner.Statement{
SQL: fmt.Sprintf(`SELECT run_id FROM %s WHERE commit_sha = @commit_sha AND status = 'closed' LIMIT 1`, spannercanceltable),
Params: map[string]interface{}{
"commit_sha": commitSha,
},
}
}

found := false
_ = a.spannerClient.Single().Query(ctx, stmt).Do(func(row *spanner.Row) error {
found = true
return nil
})
if found {
return true
}

return found
}

Expand Down