fix(morph): close dialogs properly when removing open attribute#4739
Merged
calebporzio merged 1 commit intomainfrom Feb 7, 2026
Merged
fix(morph): close dialogs properly when removing open attribute#4739calebporzio merged 1 commit intomainfrom
calebporzio merged 1 commit intomainfrom
Conversation
Morphing a `<dialog>` opened via `showModal()` would call `removeAttribute('open')` directly, leaving the dialog in the browser's top layer and making the page permanently inert. Now calls `dialog.close()` instead, which properly exits the top layer.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<dialog>that was opened viashowModal()would callremoveAttribute('open')directly. This hides the dialog visually but leaves it in the browser's top layer, making the entire page permanently inert (unclickable).<dialog>elements and callsdialog.close()instead, which properly exits the top layer.Changes
packages/morph/src/morph.js— InpatchAttributes, when removing theopenattribute from a<dialog>:tests/cypress/integration/plugins/morph.spec.js— Added test that opens a dialog viashowModal(), morphs it closed, and verifies the page remains interactive.Test plan
showModal(), morphs to removeopen, asserts dialog is closed and page is not inert🤖 Generated with Claude Code