Fix x-id evaluation order so $id resolves consistently inside x-data#4821
Merged
calebporzio merged 1 commit intomainfrom Apr 30, 2026
Merged
Fix x-id evaluation order so $id resolves consistently inside x-data#4821calebporzio merged 1 commit intomainfrom
x-id evaluation order so $id resolves consistently inside x-data#4821calebporzio merged 1 commit intomainfrom
Conversation
…data`
When `x-id` and `x-data` were on the same element, `$id('name')` calls inside
the `x-data` expression resolved to a different id than calls in descendants,
because `x-data` ran before `x-id` had a chance to register the id root.
Move `id` ahead of `data` in the directive order so the id root is set up
before `x-data` evaluates.
Fixes #4817
Collaborator
|
great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When
x-idandx-dataare on the same element,$id('name')inside thex-dataexpression returns a different id than$id('name')in descendants — breaking ARIA wiring that relies on them matching.The Problem
dataruns beforeidin the directive order. So$id('a')insidex-datafinds no_x_idson its ancestor yet and falls back to the global counter (returns1). Thenx-idruns and callsfindAndIncrementIdagain (returns2), which becomes the actual id root. Descendants resolvea-2while thex-datascope holdsa-1.The Solution
Swap
idahead ofdataindirectiveOrderso the id root is registered first.x-idonly takes a static array of name strings, so it doesn't needx-datascope to evaluate. Docs, tests, and real-world usage all use this pattern.Fixes #4817