Skip to content

Workflows#5

Merged
alsitton merged 1 commit intomainfrom
workflows
Dec 14, 2020
Merged

Workflows#5
alsitton merged 1 commit intomainfrom
workflows

Conversation

@github-learning-lab
Copy link
Copy Markdown

@github-learning-lab github-learning-lab bot commented Dec 14, 2020

This pull request covers a few common workflows that may be used within your organization.

Challenge question

Suppose you'd like to contribute to the repository pictured below. Which branch should you use as a base for your contributions?

a screenshot of a repository's branches, they are: a protected master branch, a protected release-v1.0 branch. The rest are unprotected: bug-fix, green-colors, config-release-drafter, add-template

  • main
  • release-v1.0
  • bug-fix
  • green-colors
  • config-release-drafter

I'll respond when you check one of the boxes above.

@github-learning-lab github-learning-lab bot mentioned this pull request Dec 14, 2020
4 tasks
@github-learning-lab
Copy link
Copy Markdown
Author

Answer 🔮

The real answer is that, without documentation, we don't know!

This pull request covers the basics, but here are some recommendations to help any contributor know the right way to open pull requests:

  • Use protected branches. Doing so will allow you to accept pull requests without fear of breaking production code.
  • Use CODEOWNERS in combination with protected branches to ensure the right people review changes.
  • If you haven't picked a workflow, use a common and well documented one.
  • Be explicit about your deployment and release strategy.

⌨️ Activity: Review workflow documentation

  1. Review the changes in the Files changed tab
  2. Approve this pull request (if needed)
  3. Merge this pull request
  4. Delete the branch

I'll respond when you merge this pull request.

@alsitton alsitton merged commit 48ae792 into main Dec 14, 2020
@github-learning-lab
Copy link
Copy Markdown
Author

You can find your next steps in your next pull request.

@alsitton alsitton deleted the workflows branch December 14, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants