Update Choice Generator to v1.3.4 with new features#9
Merged
Conversation
- Enhanced XML documentation generation in `Executor.cs` using dynamic cref tags. - Removed unused constant `IXmlSerializableFullName` from `Constants.cs`. - Refactored `PropertyDetails.cs` to make `TypeSymbol` read-only and simplify `IsDateOnly`. - Introduced a new test for array handling in `ChoiceGeneratorTest.cs`. - Configured `DiffTools` in `ModuleInitializer.cs` for better snapshot testing.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Choice Generator to version 1.3.4 with several enhancements focused on improving XML documentation generation and adding test coverage for array types. The main changes include dynamic cref tag generation for better type references in documentation, code cleanup, and new test infrastructure.
- Enhanced XML documentation with dynamic cref tags for improved type references
- Removed unused constant and refactored property details for better maintainability
- Added comprehensive test coverage for array handling in choice types
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Version bump to 1.3.4 |
| src/AltaSoft.Choice.Generator/Executor.cs | Enhanced XML documentation generation using dynamic cref tags |
| src/AltaSoft.Choice.Generator/Extensions/CompilationExt.cs | Added GetCrefForType method for dynamic XML documentation generation |
| src/AltaSoft.Choice.Generator/Helpers/Constants.cs | Removed unused IXmlSerializableFullName constant |
| src/AltaSoft.Choice.Generator/Models/PropertyDetails.cs | Made TypeSymbol read-only and simplified IsDateOnly method |
| tests/AltaSoft.ChoiceGenerator.Tests/ArrayInTypeChoice.cs | New test class for array handling in choice types |
| tests/AltaSoft.Choice.Generator.SnapshotTests/ChoiceGeneratorTest.cs | Added test for array in choice documentation generation |
| tests/AltaSoft.Choice.Generator.SnapshotTests/ModuleInitializer.cs | Configured DiffTools for better snapshot testing |
| tests/AltaSoft.Choice.Generator.SnapshotTests/Snapshots/ChoiceGeneratorTest.ChoiceTypeShouldGenerateDocumentationCorrectly_ForArrayInChoice#ArrayInTypeChoice.g.verified.cs | Generated snapshot for array choice documentation test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executor.csusing dynamic cref tags.IXmlSerializableFullNamefromConstants.cs.PropertyDetails.csto makeTypeSymbolread-only and simplifyIsDateOnly.ChoiceGeneratorTest.cs.DiffToolsinModuleInitializer.csfor better snapshot testing.