Skip to content

Feature/net10 updates#17

Merged
temonk merged 2 commits intomainfrom
feature/net10Updates
Jan 12, 2026
Merged

Feature/net10 updates#17
temonk merged 2 commits intomainfrom
feature/net10Updates

Conversation

@temonk
Copy link
Copy Markdown
Contributor

@temonk temonk commented Jan 12, 2026

No description provided.

Temo Nikolaishvili added 2 commits January 5, 2026 15:13
Centralized framework configuration, updated CI workflows, and revised build/test properties.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the project to target .NET 10 and implements centralized package version management. However, it references versions and frameworks that do not yet exist as of January 2025.

Changes:

  • Adds .NET 10.0 as a target framework across the solution
  • Introduces centralized package management via Directory.Packages.props
  • Updates package versions to newer (unreleased) versions
  • Adds required modifiers to several test model properties for improved null safety
  • Makes nullable annotations more explicit in test models
  • Updates test assertions to use more idiomatic xUnit methods
  • Removes UTF-8 BOM characters from project files
  • Updates Visual Studio solution file version to 18

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Directory.Build.props Adds net10.0 to target frameworks, updates version to 2.0.0, adds CI build properties and symbol package configuration
Directory.Packages.props New file introducing centralized package version management with updated package versions
src/AltaSoft.Simpra/AltaSoft.Simpra.csproj Migrates to use DefaultTargetFrameworks variable and centralized package versions, adds symbol package configuration
src/AltaSoft.Simpra.Metadata/AltaSoft.Simpra.Metadata.csproj Migrates to DefaultTargetFrameworks and centralized packages, adds project reference to AltaSoft.Simpra, adds symbol package configuration
tests/AltaSoft.Simpra.tests/AltaSoft.Simpra.Tests.csproj Targets net10.0, removes BOM character, migrates to centralized packages, updates DomainPrimitiveGenerator property name
tests/AltaSoft.Simpra.Benchmark/AltaSoft.Simpra.Benchmark.csproj Removes BOM character and migrates to centralized package versions
tests/AltaSoft.Simpra.tests/Models/TestModel.cs Makes Ccy and CustomerList properties nullable, removes explicit 'public' from interface members
tests/AltaSoft.Simpra.tests/Models/Transfer.cs Adds nullable annotation to Customer property and required modifiers to other properties
tests/AltaSoft.Simpra.tests/SimpraMetaDataTest.cs Adds required modifiers to collection and reference type properties
tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs Updates assertion from Assert.Equal(null, result) to Assert.Null(result)
tests/AltaSoft.Simpra.tests/UnitTestsSmartPurposeModel.cs Removes trailing blank lines
.github/workflows/publish_nuget.yml Adds .NET 10.0.x SDK to the setup
.github/workflows/dotnet.yml Adds .NET 10.0.x SDK to the setup
.github/workflows/build_nuget_dont_publish.yml Adds .NET 10.0.x SDK to the setup
AltaSoft.Simpra.sln Updates Visual Studio version to 18, adds Directory.Packages.props, reorganizes solution structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@temonk temonk merged commit 8469128 into main Jan 12, 2026
7 checks passed
@temonk temonk deleted the feature/net10Updates branch January 12, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants