Added comprehensive null-safety tests for dictionary and property acc…#19
Merged
Added comprehensive null-safety tests for dictionary and property acc…#19
Conversation
added 2 commits
April 8, 2026 18:04
…ess. Updated SimpraParserVisitor for null-safe dictionary indexing and revised test data for substring edge cases. Updated NuGet package versions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Simpra DSL null-safety around dictionary indexing (preventing null dictionary access from throwing) and adds/updates tests to validate the behavior, alongside routine package/version bumps.
Changes:
- Updated
SimpraParserVisitorto null-check dictionaries before callingTryGetValueduring index access. - Added a large suite of null-safety tests for dictionary/list/property access chains.
- Updated test data for substring edge cases and bumped NuGet/package versions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/AltaSoft.Simpra.tests/SimpraExpressionTests.cs | Updates substring edge-case tests; adds an extra test (currently misplaced/typoed) |
| tests/AltaSoft.Simpra.tests/NullSafetyTests.cs | Adds comprehensive null-safety coverage for dictionary/list/property access patterns |
| tests/AltaSoft.Simpra.tests/Models/DebtorAccount.cs | Introduces a model used by the new null-safety tests |
| src/AltaSoft.Simpra/Visitor/SimpraParserVisitor.cs | Implements null-safe dictionary index access in the visitor |
| Directory.Packages.props | Updates dependency versions |
| Directory.Build.props | Bumps project version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ess.
Updated SimpraParserVisitor for null-safe dictionary indexing and revised test data for substring edge cases. Updated NuGet package versions.